Skip to content

Conversation

@tuj
Copy link
Contributor

@tuj tuj commented Oct 23, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2321

Description

  • Added checkbox options component for use in calendar modifiers.
  • Fixed multiselect when more than one feed source of the given type is installed.
  • Fixed github action to fail on warnings.

Screenshot of the result

Screenshot 2024-10-23 at 13 59 43

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj added the enhancement New feature or request label Oct 23, 2024
@tuj tuj self-assigned this Oct 23, 2024
@tuj tuj marked this pull request as ready for review November 20, 2024 11:51
@tuj tuj requested a review from sinejespersen November 21, 2024 13:29
value={option.value}
onChange={onOptionChange}
checked={containsValue(option.value)}
/>{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is {" "} on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@tuj tuj merged commit e1f2fa3 into develop Nov 22, 2024
4 checks passed
@tuj tuj deleted the feature/2321-checkbox-options branch November 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants